fix(compat): correct injectors to fix issue with compat API on v19 #3595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosostolato
commented
Dec 19, 2024
jamesdaniels
approved these changes
Dec 22, 2024
|
Cool. Thanks for this. Unfortunately my compat test app is still broken, so I wasn't able to verify. Was on my list to do before v19 final. |
rosostolato
force-pushed
the
fix-compat-v19
branch
from
e7e0866 to
18b61e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
yarn install,yarn testrun successfully? yesDescription
Fix compat api methods to work with the updates from #3586.
Code sample
No change to the API usage.